Setting to use Django's cache#430
Open
mitchelljkotler wants to merge 2 commits intoSmileyChris:masterfrom
Open
Setting to use Django's cache#430mitchelljkotler wants to merge 2 commits intoSmileyChris:masterfrom
mitchelljkotler wants to merge 2 commits intoSmileyChris:masterfrom
Conversation
Collaborator
|
Thanks for this pull request, but no unit tests are provided. Please add them before approving it. |
jrief
requested changes
Oct 31, 2017
Collaborator
jrief
left a comment
jrief
left a comment
There was a problem hiding this comment.
This pull request adds additional complexity.
Without a unit test covering this code, it won't be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to address #342, caching source and thumbnail models in Django's cache in order to avoid excessive SQL queries.